Skip to content

Skip torch random ops in CoreML partitioner#19246

Open
john-rocky wants to merge 2 commits intopytorch:mainfrom
john-rocky:coreml/skip-random-ops
Open

Skip torch random ops in CoreML partitioner#19246
john-rocky wants to merge 2 commits intopytorch:mainfrom
john-rocky:coreml/skip-random-ops

Conversation

@john-rocky
Copy link
Copy Markdown

@john-rocky john-rocky commented May 1, 2026

Summary

coremltools' MIL converter fails the input-count check for the torch random
ops (rand / randn / rand_like / randn_like / randint /
randint_like) and aborts during compilation with an internal error
(see issue for the full traceback).

Add these ops to should_override_support so the partitioner refuses to
delegate them and they fall back to the portable backend, the same way
acosh / asinh are handled today.

Fixes #11722.

Test plan

Added test_random_ops_are_skipped which lowers a model that adds
torch.randn + torch.rand outputs and asserts the random ops remain in
the top-level graph (not delegated). Also reproduced the original
randn_like repro from the issue and confirmed it now lowers without
crashing:

$ python -m unittest -v executorch.backends.apple.coreml.test.test_coreml_partitioner.TestCoreMLPartitioner.test_random_ops_are_skipped
Ran 1 test in 0.475s

OK

Authored with Claude.

@john-rocky
Skip torch random ops in CoreML partitioner
976bf72 
coremltools' converter fails the input-count check for the torch
random ops (rand / randn / rand_like / randn_like / randint /
randint_like) and aborts with an internal error during CoreML
compilation.  Reject them in the partitioner so they fall back to
the portable backend.

Fixes pytorch#11722.
@john-rocky john-rocky requested a review from shoumikhin as a code owner May 1, 2026 04:47
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 1, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19246

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 12 Awaiting Approval

As of commit 3c651e8 with merge base 94d2881 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 1, 2026

Hi @john-rocky!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CoreML randn_like fails to lower with internal error

1 participant

@john-rocky